Skip to content

feat(no-ignored-default-value): new rule for enforcing defaultValue #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 16, 2024
Merged

feat(no-ignored-default-value): new rule for enforcing defaultValue #15

merged 3 commits into from
Nov 16, 2024

Conversation

JasonWeinzierl
Copy link
Owner

@JasonWeinzierl JasonWeinzierl commented Nov 11, 2024 •
edited
Loading

Introduces a new rule that enforces defaultValue to be passed into firstValueFrom, lastValueFrom, first, and last, in order to prevent EmptyError.

Resolves upstream cartant#126

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

LCOV of commit 9ce4f40 during .github/workflows/ci.yml #85

Summary coverage rate:
  lines......: 96.3% (3391 of 3520 lines)
  functions..: 95.0% (211 of 222 functions)
  branches...: 91.5% (659 of 720 branches)

Files changed coverage rate:
                                         |Lines       |Functions  |Branches    
  Filename                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================
  src/index.ts                           | 100%     99|    -     0|    -      0
  src/rules/no-ignored-default-value.ts  |98.0%    102| 100%    10|97.0%     33
  src/rules/no-ignored-replay-buffer.ts  | 100%     75| 100%     7| 100%     13

@JasonWeinzierl JasonWeinzierl force-pushed the no-ignored-default-value branch from bc507e6 to fce2bee Compare November 16, 2024 05:04
@JasonWeinzierl JasonWeinzierl force-pushed the no-ignored-default-value branch from fce2bee to 9ce4f40 Compare November 16, 2024 05:35
@JasonWeinzierl JasonWeinzierl merged commit 9bd896e into main Nov 16, 2024
2 checks passed
@JasonWeinzierl JasonWeinzierl deleted the no-ignored-default-value branch November 16, 2024 05:38
@JasonWeinzierl JasonWeinzierl added the enhancement New feature or request label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JasonWeinzierl